lkml.org 
[lkml]   [2011]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kernel/printk: do not turn off bootconsole in printk_late_init if keep_bootcon
    On 8/10/2011 2:02 AM, Nishanth Aravamudan wrote:
    > It seems that commit 7bf693951a8e5f7e600a45b74d91d962a453146e doesn't
    > always achieve what it aims, as printk_late_init() runs it
    > unconditionally turns off all boot consoles. With this patch, I am able
    > to see more messages on the boot console in KVM guests than I can
    > without, when keep_bootcon is specified.
    >
    > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
    > Cc: David S. Miller <davem@davemloft.net>
    > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    > Cc: Greg KH <gregkh@suse.de>
    > ---
    > kernel/printk.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/kernel/printk.c b/kernel/printk.c
    > index 37dff34..293a6cc 100644
    > --- a/kernel/printk.c
    > +++ b/kernel/printk.c
    > @@ -1602,7 +1602,7 @@ static int __init printk_late_init(void)
    > struct console *con;
    >
    > for_each_console(con) {
    > - if (con->flags & CON_BOOT) {
    > + if (!keep_bootcon && con->flags & CON_BOOT) {
    > printk(KERN_INFO "turn off boot console %s%d\n",
    > con->name, con->index);
    > unregister_console(con);

    Patch looks ok to me, just send it through the right channels for inclusion.

    Fabio


    \
     
     \ /
      Last update: 2011-08-15 14:13    [W:0.042 / U:29.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site