[lkml]   [2011]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[27/90] drm/i915: Hold mode_config->mutex during hotplug processing
    3.0-stable review patch.  If anyone has any objections, please let us know.


    From: Keith Packard <>

    commit a65e34c79c88895766ab1f8a5afa451eed26622b upstream.

    Hotplug detection is a mode setting operation and must hold the
    struct_mutex or risk colliding with other mode setting operations.

    In particular, the display port hotplug function attempts to re-train
    the link if the monitor is supposed to be running when plugged back
    in. If that happens while mode setting is underway, the link will get
    scrambled, leaving it in an inconsistent state.

    This is a special case -- usually the driver mode setting entry points
    are covered by the upper level DRM code, but in this case the function
    is invoked as a work function not under the control of DRM.

    Signed-off-by: Keith Packard <>
    Reviewed-by: Jesse Barnes <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/gpu/drm/i915/i915_irq.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/gpu/drm/i915/i915_irq.c
    +++ b/drivers/gpu/drm/i915/i915_irq.c
    @@ -306,6 +306,7 @@ static void i915_hotplug_work_func(struc
    struct drm_mode_config *mode_config = &dev->mode_config;
    struct intel_encoder *encoder;

    + mutex_lock(&mode_config->mutex);
    DRM_DEBUG_KMS("running encoder hotplug functions\n");

    list_for_each_entry(encoder, &mode_config->encoder_list, base.head)
    @@ -314,6 +315,8 @@ static void i915_hotplug_work_func(struc

    /* Just fire off a uevent and let userspace tell us what to do */
    + mutex_unlock(&mode_config->mutex);

    static void i915_handle_rps_change(struct drm_device *dev)

     \ /
      Last update: 2011-08-14 18:11    [W:0.032 / U:34.364 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site