Messages in this thread Patch in this message | | | Date | Sun, 14 Aug 2011 15:38:08 GMT | From | tip-bot for Vasiliy Kulikov <> | Subject | [tip:perf/core] perf: fix temporary file ownership check |
| |
Commit-ID: e9b52ef2228cd0bed7a4465c693a39489e2c338d Gitweb: http://git.kernel.org/tip/e9b52ef2228cd0bed7a4465c693a39489e2c338d Author: Vasiliy Kulikov <segoon@openwall.com> AuthorDate: Fri, 12 Aug 2011 00:55:37 +0400 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Fri, 12 Aug 2011 08:28:17 -0300
perf: fix temporary file ownership check
A file in /tmp/ might be a symlink, so lstat() should be used instead of stat().
Acked-by: Pekka Enberg <penberg@kernel.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Pekka Enberg <penberg@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20110811205537.GA22864@albatros Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/symbol.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index e142c21..469c026 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -1506,7 +1506,7 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) if (strncmp(dso->name, "/tmp/perf-", 10) == 0) { struct stat st; - if (stat(dso->name, &st) < 0) + if (lstat(dso->name, &st) < 0) return -1; if (st.st_uid && (st.st_uid != geteuid())) {
| |