[lkml]   [2011]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[tip:sched/core] sched: Balance RT tasks when forked as well
    Commit-ID:  c37495fd0f64fc139b5a07d242bcb485174d1206
    Author: Steven Rostedt <>
    AuthorDate: Thu, 16 Jun 2011 21:55:22 -0400
    Committer: Ingo Molnar <>
    CommitDate: Sun, 14 Aug 2011 12:00:52 +0200

    sched: Balance RT tasks when forked as well

    When a new task is woken, the code to balance the RT task is currently
    skipped in the select_task_rq() call. But it will be pushed if the rq
    is currently overloaded with RT tasks anyway. The issue is that we
    already queued the task, and if it does get pushed, it will have to
    be dequeued and requeued on the new run queue. The advantage with
    pushing it first is that we avoid this requeuing as we are pushing it
    off before the task is ever queued.

    See commit 318e0893ce3f524 ("sched: pre-route RT tasks on wakeup")
    for more details.

    The return of select_task_rq() when it is not a wake up has also been
    changed to return task_cpu() instead of smp_processor_id(). This is more
    of a sanity because the current only other user of select_task_rq()
    besides wake ups, is an exec, where task_cpu() should also be the same
    as smp_processor_id(). But if it is used for other purposes, lets keep
    the task on the same CPU. Why would we mant to migrate it to the current

    Signed-off-by: Steven Rostedt <>
    Signed-off-by: Peter Zijlstra <>
    Cc: Hillf Danton <>
    Signed-off-by: Ingo Molnar <>
    kernel/sched_rt.c | 9 ++++++---
    1 files changed, 6 insertions(+), 3 deletions(-)

    diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
    index 70107a3..2153a87 100644
    --- a/kernel/sched_rt.c
    +++ b/kernel/sched_rt.c
    @@ -1017,10 +1017,12 @@ select_task_rq_rt(struct task_struct *p, int sd_flag, int flags)
    struct rq *rq;
    int cpu;

    - if (sd_flag != SD_BALANCE_WAKE)
    - return smp_processor_id();
    cpu = task_cpu(p);
    + /* For anything but wake ups, just return the task_cpu */
    + if (sd_flag != SD_BALANCE_WAKE && sd_flag != SD_BALANCE_FORK)
    + goto out;
    rq = cpu_rq(cpu);

    @@ -1059,6 +1061,7 @@ select_task_rq_rt(struct task_struct *p, int sd_flag, int flags)

    return cpu;

     \ /
      Last update: 2011-08-14 18:33    [W:0.025 / U:8.716 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site