lkml.org 
[lkml]   [2011]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/4] msm_serial: Add devicetree support
    Date
    On Friday 12 August 2011 16:00:06 David Brown wrote:
    > +Required properties:
    > +- compatible :
    > + - "qcom,msm-uart"
    > +- reg : offset and length of the register set for the device
    > + for the hsuart operating in compatible mode, there should be a
    > + second pair describing the gsbi registers.
    > +- interrupts : should contain the uart interrupt.
    > +
    > +Example:
    > +
    > + uart@19c400000 {
    > + compatible = "qcom,msm-hsuart", "qcom,msm-uart";
    > + reg = <0x19c40000 0x1000">,
    > + <0x19c00000 0x1000">;
    > + interrupts = <195>;
    > + };



    > @@ -920,11 +928,17 @@ static int __devexit msm_serial_remove(struct platform_device *pdev)
    > return 0;
    > }
    >
    > +static struct of_device_id msm_match_table[] = {
    > + { .compatible = "qcom,msm-hsuart-lite" },
    > + {}
    > +};
    > +

    Hi David,

    It looks like you changed the value for the "compatible" property in the
    process of making the patch, but did not update all places.

    Should it be qcom,msm-hsuart-lite or qcom,msm-hsuart?

    Arnd


    \
     
     \ /
      Last update: 2011-08-13 10:31    [W:0.023 / U:0.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site