Messages in this thread | | | Date | Sat, 13 Aug 2011 18:05:31 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge struct by value |
| |
Hi all,
On Sat, 13 Aug 2011 01:04:36 +0200 (CEST) Jesper Juhl <jj@chaosbits.net> wrote: > > From: Jesper Juhl <jj@chaosbits.net> > Date: Sat, 13 Aug 2011 00:51:40 +0200 > > struct ieee80211_network is fairly large (more than half a kilobyte), > so let's pass a pointer instead of passing the entire structure by > value when ieee80211_is_54g() and ieee80211_is_shortslot() need to > look at a few members. > Also remove parentheses around the values being returned from those > two functions - 'return' is not a function.
Also, is there some reason that they are not "static inline bool" functions defined directlt in ieee80211.h?
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |