Messages in this thread | | | Date | Fri, 12 Aug 2011 09:56:49 +0100 | From | Alan Cox <> | Subject | Re: [RFC PATCH] vhost-blk: An in-kernel accelerator for virtio-blk |
| |
On Thu, 11 Aug 2011 21:59:25 +0200 Dongsu Park <dongsu.park@profitbricks.com> wrote:
> Hi, > > On 07/28/2011 05:22 PM, Michael S. Tsirkin wrote: > > On Thu, Jul 28, 2011 at 10:29:05PM +0800, Liu Yuan wrote: > >> +static struct miscdevice vhost_blk_misc = { > >> + 234, > > > > Don't get a major unless you really must. > > the minor number 234 conflicts with that of BTRFS, in kernel 3.0 at least. > Therefore you cannot load vhost_blk.ko if btrfs.ko was already loaded. > Probably that number should be something else, with which you don't have > conflict with any minor number in include/linux/miscdevice.h.
It should be zero or it should be officially reserved in devices.txt via lanana@kernel.org, who (for it happens to be me currently) will turn it down and tell you to use 0 to get a dynamic allocation unless you can provide a very good reason that isn't suitable.
| |