lkml.org 
[lkml]   [2011]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] vhost-blk: An in-kernel accelerator for virtio-blk
    On Thu, 11 Aug 2011 21:59:25 +0200
    Dongsu Park <dongsu.park@profitbricks.com> wrote:

    > Hi,
    >
    > On 07/28/2011 05:22 PM, Michael S. Tsirkin wrote:
    > > On Thu, Jul 28, 2011 at 10:29:05PM +0800, Liu Yuan wrote:
    > >> +static struct miscdevice vhost_blk_misc = {
    > >> + 234,
    > >
    > > Don't get a major unless you really must.
    >
    > the minor number 234 conflicts with that of BTRFS, in kernel 3.0 at least.
    > Therefore you cannot load vhost_blk.ko if btrfs.ko was already loaded.
    > Probably that number should be something else, with which you don't have
    > conflict with any minor number in include/linux/miscdevice.h.

    It should be zero or it should be officially reserved in devices.txt via
    lanana@kernel.org, who (for it happens to be me currently) will turn it
    down and tell you to use 0 to get a dynamic allocation unless you can
    provide a very good reason that isn't suitable.


    \
     
     \ /
      Last update: 2011-08-12 10:57    [W:5.080 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site