lkml.org 
[lkml]   [2011]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] perf, x86: Implement 64 bit counter support for IBS
    On 02.08.11 07:37:20, Peter Zijlstra wrote:
    > On Thu, 2011-07-28 at 15:46 +0200, Robert Richter wrote:
    > > + /*
    > > + * Emulate IbsOpCurCnt in MSRC001_1033 (IbsOpCtl), not
    > > + * supported in all cpus. As this triggered an interrupt, we
    > > + * set the current count to the max count.
    > > + */
    > > + config = buffer[0];
    > > + if (perf_ibs == &perf_ibs_op) {
    > > + config &= ~IBS_OP_CUR_CNT;
    > > + config |= (config & IBS_OP_MAX_CNT) << 36;
    > > + }
    >
    > Shouldn't that be conditional on capability muck?

    It doesn't hurt actually, but true, will implement it right with the
    capability check.

    -Robert

    --
    Advanced Micro Devices, Inc.
    Operating System Research Center



    \
     
     \ /
      Last update: 2011-08-12 20:17    [W:4.234 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site