lkml.org 
[lkml]   [2011]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] pnp: replace deprecated __check_region to request_region
On Thu, Aug 11, 2011 at 10:03 PM, Wang Shaoyan <stufever@gmail.com> wrote:
> I can understand your worry, but back to beginning, just as the
> subject of the patch: "replace deprecated __check_region to
> request_region", I think this patch is still need, although it can't
> solve the problems both you guys mentioned. Do you agree it?

Your patch is presented as "no functional change," but in fact, the
current code does not leave the region reserved, while with your patch
it does. This is quite a large change and I think it will break
things.

I would like to see the PNP core reserve resources, but it should be
done for all resources of all device. Your patch only affects ioports
(I think we should do memory as well), and it only affects the
assignment path (I don't think we do this for every device we
enumerate). And it effectively adds a region reservation without
adding a corresponding release.

Bjorn


\
 
 \ /
  Last update: 2011-08-12 18:27    [W:0.043 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site