lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2][cleanup] memcg: renaming of mem variable to memcg
On 08/11/2011 01:34 PM, Michal Hocko wrote:
> On Wed 10-08-11 22:59:29, Raghavendra K T wrote:
> [...]
>> This patch renames all mem variables to memcg in source file.
>
> __mem_cgroup_try_charge for example uses local mem which cannot be
> renamed because it already has a memcg argument (mem_cgroup **) then we
> have mem_cgroup_try_charge_swapin and mem_cgroup_prepare_migration which
> use mem_cgroup **ptr (I guess we shouldn't have more of them).
> I think that __mem_cgroup_try_charge should use ptr pattern as well.
> Other than that I think the clean up is good.
>
> With __mem_cgroup_try_charge:
> Acked-by: Michal Hocko<mhocko@suse.cz>
>
> Thanks
Agreed, Let me know whether you prefer whole patch to be posted or only
the corresponding hunk.
Thanks


\
 
 \ /
  Last update: 2011-08-11 11:01    [W:0.083 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site