lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 1/2] Track hard and soft "short lockups" or "stalls."
From
Date
On Wed, 2011-08-10 at 11:02 -0700, Alex Neronskiy wrote:
> @@ -767,7 +767,23 @@ static struct ctl_table kern_table[] = {
> .extra1 = &zero,
> .extra2 = &one,
> },
> -#endif
> + {
> + .procname = "softstall_worst",
> + .data = &worst_softstall,
> + .maxlen = sizeof(unsigned long),
> + .mode = 0644,
> + .proc_handler = proc_doulongvec_minmax,
> + },
> +#ifdef CONFIG_HARDLOCKUP_DETECTOR
> + {
> + .procname = "hardstall_worst",
> + .data = &worst_hardstall,
> + .maxlen = sizeof(unsigned long),
> + .mode = 0644,
> + .proc_handler = proc_doulongvec_minmax,
> + },
> +#endif /* CONFIG_HARDLOCKUP_DETECTOR */
> +#endif /* CONFIG_LOCKUP_DETECTOR */

And patch 2 does:


> +++ b/kernel/sysctl.c
> @@ -767,22 +767,6 @@ static struct ctl_table kern_table[] = {
> .extra1 = &zero,
> .extra2 = &one,
> },
> - {
> - .procname = "softstall_worst",
> - .data = &worst_softstall,
> - .maxlen = sizeof(unsigned long),
> - .mode = 0644,
> - .proc_handler = proc_doulongvec_minmax,
> - },
> -#ifdef CONFIG_HARDLOCKUP_DETECTOR
> - {
> - .procname = "hardstall_worst",
> - .data = &worst_hardstall,
> - .maxlen = sizeof(unsigned long),
> - .mode = 0644,
> - .proc_handler = proc_doulongvec_minmax,
> - },
> -#endif /* CONFIG_HARDLOCKUP_DETECTOR */
> #endif /* CONFIG_LOCKUP_DETECTOR */
>

Makes one wonder wtf patch 1 exists for..


\
 
 \ /
  Last update: 2011-08-11 21:13    [from the cache]
©2003-2011 Jasper Spaans