lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -tip v2 4/9] [BUGFIX] perf probe: Fix to walk all inline instances
    Date
    Fix line-range collector to walk all instances of inlined
    function, because some execution paths can be optimized out
    depends on the function argument of instances.

    E.g.)
    inline_func (arg) {
    if (arg)
    do_something;
    else
    do_another;
    }

    func_A() {
    inline_func(1)
    }

    func_B() {
    inline_func(0)
    }

    In this case, func_A may have only do_something code and
    func_B may have only do_another.

    Signed-off-by: Masami Hiramatsu <masami.hiramatsu@gmail.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
    ---

    tools/perf/util/probe-finder.c | 8 +++++++-
    1 files changed, 7 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
    index 573c723..d6d5768 100644
    --- a/tools/perf/util/probe-finder.c
    +++ b/tools/perf/util/probe-finder.c
    @@ -1393,7 +1393,13 @@ static int line_range_inline_cb(Dwarf_Die *in_die, void *data)
    struct dwarf_callback_param *param = data;

    param->retval = find_line_range_by_line(in_die, param->data);
    - return DWARF_CB_ABORT; /* No need to find other instances */
    +
    + /*
    + * We have to check all instances of inlined function, because
    + * some execution paths can be optimized out depends on the
    + * function argument of instances
    + */
    + return DWARF_CB_OK;
    }

    /* Search function from function name */


    \
     
     \ /
      Last update: 2011-08-11 13:29    [W:4.250 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site