Messages in this thread | | | Subject | Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' | From | David Woodhouse <> | Date | Thu, 11 Aug 2011 12:10:10 +0100 |
| |
On Thu, 2011-08-11 at 10:58 +0200, Michal Marek wrote: > I would much rather see include/config/auto.conf reset all configuration > variables to match what kconfig computed. I.e. use 'undefine CONFIG_FOO' > instead of '# CONFIG_FOO is not set'.
That would be cute, but I'm not sure how to undefine something set on the command line:
$ cat > Makefile <<EOF undefine BAR
foo: echo $(BAR) EOF $ make foo BAR=hh echo hh hh
Arguably, if someone *does* try something like Arnaud's "make CONFIG_FOO_BAR=y oldconfig bzImage" .. and it *wasn't* able to set CONFIG_FOO_BAR, then the nicest behaviour would be to fail, rather than to attempt to build it.
So perhaps we should clean up only those settings inherited from the environment, and still (as in the patch I sent earlier) refuse to allow build targets in conjunction with CONFIG overrides on the command line?
-- dwmw2
| |