lkml.org 
[lkml]   [2011]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] led: fix memory leak
led: fix memory leak

The memory for struct led_trigger should be properly kfreed in the case of
error of led_trigger_register(). Also this function should return NULL if
error.

Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>

---
drivers/leds/led-triggers.c | 5 4 + 1 - 0 !
1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -261,9 +261,12 @@ void led_trigger_register_simple(const c
if (trigger) {
trigger->name = name;
err = led_trigger_register(trigger);
- if (err < 0)
+ if (err < 0) {
+ kfree(trigger);
+ trigger = NULL;
printk(KERN_WARNING "LED trigger %s failed to register"
" (%d)\n", name, err);
+ }
} else
printk(KERN_WARNING "LED trigger %s failed to register"
" (no memory)\n", name);


\
 
 \ /
  Last update: 2011-08-10 09:57    [W:1.828 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site