Messages in this thread | | | Subject | Re: [PATCH v2] Fix leak in drivers/target/iscsi/iscsi_target_parameters.c::iscsi_copy_param_list() | From | Joe Perches <> | Date | Mon, 01 Aug 2011 16:32:22 -0700 |
| |
On Mon, 2011-08-01 at 22:32 +0200, Jesper Juhl wrote: > diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c [] > @@ -572,6 +572,17 @@ int iscsi_copy_param_list( [] > + if (!new_param->name || !new_param->value) { [] > + pr_err("Unable to allocate memory for parameter " > + "name/value.\n");
I know you didn't change these lines, but could you please remember to coalesce formats to a single line next time?
| |