Messages in this thread | | | Date | Mon, 1 Aug 2011 20:15:12 +0400 | From | Konstantin Khlebnikov <> | Subject | Re: [PATCH RFC] mm: reverse lru scanning order |
| |
sorry, this patch is broken.
Konstantin Khlebnikov wrote: > LRU scanning order was accidentially changed in commit v2.6.27-5584-gb69408e: > "vmscan: Use an indexed array for LRU variables". > Before that commit reclaimer always scan active lists first. > > This patch just reverse it back. > This is just notice and question: "Does it affect something?" > > Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org> > --- > include/linux/mmzone.h | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index be1ac8d..88fb49c 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -141,7 +141,8 @@ enum lru_list { > > #define for_each_lru(l) for (l = 0; l< NR_LRU_LISTS; l++) > > -#define for_each_evictable_lru(l) for (l = 0; l<= LRU_ACTIVE_FILE; l++) > +#define for_each_evictable_lru(l) \ > + for (l = LRU_ACTIVE_FILE; l>= LRU_INACTIVE_ANON; l--)
there must be some thing like this:
+#define for_each_evictable_lru(l) \ + for (l = LRU_ACTIVE_FILE; (int)l>= LRU_INACTIVE_ANON; l--)
otherwise gcc silently generates there infinite loop =)
> > static inline int is_file_lru(enum lru_list l) > { >
| |