lkml.org 
[lkml]   [2011]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mrst_pmu: driver for Intel Moorestown Power Management Unit
On Mon, 01 Aug 2011 11:24:45 -0400 (EDT)
Len Brown <lenb@kernel.org> wrote:

>
> > > + BUG_ON(pci_dev_num != mrst_devs[index].pci_dev_num);
> >
> > That strikes me as needlessly unfriendly, you could warn/return NULL and
> > propogate a WARN_ONCE back to the user.
>
> If a fit of friendlyness, I wrote the patch below.
> Let me know if it is not what you had in mind.

It's not so much the bug on as the fact it spews these if you boot it on
a non mrst box built with a generic kernel - which was the second part of
my comment and doesn't appear addressed.


\
 
 \ /
  Last update: 2011-08-01 17:39    [W:0.147 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site