Messages in this thread | | | Date | Mon, 1 Aug 2011 07:27:12 +0200 | From | Robert Richter <> | Subject | Re: [PATCH 2/7] perf, x86: Implement IBS initialization |
| |
On 29.07.11 12:58:45, Peter Zijlstra wrote: > On Thu, 2011-07-28 at 15:46 +0200, Robert Richter wrote: > > +static int perf_ibs_add(struct perf_event *event, int flags) > > +{ > > + pr_info("Adding event %p (config=%016llx) to pmu %s (type=%d) on cpu %d\n", > > + event, event->attr.config, perf_ibs.name, event->attr.type, event->oncpu); > > + return 0; > > +} > > + > > +static void perf_ibs_del(struct perf_event *event, int flags) > > +{ > > + pr_info("Removing event %p (config=%016llx) to pmu %s (type=%d) on cpu %d\n", > > + event, event->attr.config, perf_ibs.name, event->attr.type, event->oncpu); > > +} > > While I see you remove them later on, I do find it somewhat strange to > have them here. This is user triggerable code in the context switch > path, lots of nasty can come from this.
I will remove it and simply replace it with function stubs.
-Robert
-- Advanced Micro Devices, Inc. Operating System Research Center
| |