lkml.org 
[lkml]   [2011]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[16/35] i2c-taos-evm: Fix log messages
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jean Delvare <khali@linux-fr.org>

    commit 9b640f2e154268cb516efcaf9c434f2e73c6783e upstream.

    * Print all error and information messages even when debugging is
    disabled.
    * Don't use adapter device to log messages before it is ready.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/i2c/busses/i2c-taos-evm.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/i2c/busses/i2c-taos-evm.c
    +++ b/drivers/i2c/busses/i2c-taos-evm.c
    @@ -234,7 +234,7 @@ static int taos_connect(struct serio *se

    if (taos->state != TAOS_STATE_IDLE) {
    err = -ENODEV;
    - dev_dbg(&serio->dev, "TAOS EVM reset failed (state=%d, "
    + dev_err(&serio->dev, "TAOS EVM reset failed (state=%d, "
    "pos=%d)\n", taos->state, taos->pos);
    goto exit_close;
    }
    @@ -255,7 +255,7 @@ static int taos_connect(struct serio *se
    msecs_to_jiffies(250));
    if (taos->state != TAOS_STATE_IDLE) {
    err = -ENODEV;
    - dev_err(&adapter->dev, "Echo off failed "
    + dev_err(&serio->dev, "TAOS EVM echo off failed "
    "(state=%d)\n", taos->state);
    goto exit_close;
    }
    @@ -263,7 +263,7 @@ static int taos_connect(struct serio *se
    err = i2c_add_adapter(adapter);
    if (err)
    goto exit_close;
    - dev_dbg(&serio->dev, "Connected to TAOS EVM\n");
    + dev_info(&serio->dev, "Connected to TAOS EVM\n");

    taos->client = taos_instantiate_device(adapter);
    return 0;
    @@ -288,7 +288,7 @@ static void taos_disconnect(struct serio
    serio_set_drvdata(serio, NULL);
    kfree(taos);

    - dev_dbg(&serio->dev, "Disconnected from TAOS EVM\n");
    + dev_info(&serio->dev, "Disconnected from TAOS EVM\n");
    }

    static struct serio_device_id taos_serio_ids[] = {



    \
     
     \ /
      Last update: 2011-07-09 08:11    [W:4.529 / U:21.008 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site