lkml.org 
[lkml]   [2011]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[30/35] net: filter: Use WARN_RATELIMIT
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Joe Perches <joe@perches.com>

    [ Upstream commit 6c4a5cb219520c7bc937ee186ca53f03733bd09f ]

    A mis-configured filter can spam the logs with lots of stack traces.

    Rate-limit the warnings and add printout of the bogus filter information.

    Original-patch-by: Ben Greear <greearb@candelatech.com>
    Signed-off-by: Joe Perches <joe@perches.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    net/core/filter.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/net/core/filter.c
    +++ b/net/core/filter.c
    @@ -285,7 +285,9 @@ load_b:
    mem[fentry->k] = X;
    continue;
    default:
    - WARN_ON(1);
    + WARN_RATELIMIT(1, "Unknown code:%u jt:%u tf:%u k:%u\n",
    + fentry->code, fentry->jt,
    + fentry->jf, fentry->k);
    return 0;
    }




    \
     
     \ /
      Last update: 2011-07-09 08:07    [W:0.021 / U:29.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site