lkml.org 
[lkml]   [2011]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[32/35] net/ipv4: Check for mistakenly passed in non-IPv4 address
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Marcus Meissner <meissner@suse.de>

    [ Upstream commit d0733d2e29b652b2e7b1438ececa732e4eed98eb ]

    Check against mistakenly passing in IPv6 addresses (which would result
    in an INADDR_ANY bind) or similar incompatible sockaddrs.

    Signed-off-by: Marcus Meissner <meissner@suse.de>
    Cc: Reinhard Max <max@suse.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    net/ipv4/af_inet.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/net/ipv4/af_inet.c
    +++ b/net/ipv4/af_inet.c
    @@ -461,6 +461,9 @@ int inet_bind(struct socket *sock, struc
    if (addr_len < sizeof(struct sockaddr_in))
    goto out;

    + if (addr->sin_family != AF_INET)
    + goto out;
    +
    chk_addr_ret = inet_addr_type(sock_net(sk), addr->sin_addr.s_addr);

    /* Not specified by any standard per-se, however it breaks too



    \
     
     \ /
      Last update: 2011-07-09 08:07    [W:0.030 / U:181.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site