[lkml]   [2011]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subjectkmallocs with swapped parameters in fs/dlm/lock.c
Hi David,
Sparse spotted a couple of places in fs/dlm/lock.c where the size/flags
parameters to kmalloc got swapped:

The sparse output is:
fs/dlm/lock.c:852:42: warning: incorrect type in argument 1 (different base types)
fs/dlm/lock.c:852:42: expected unsigned long [unsigned] [usertype] size
fs/dlm/lock.c:852:42: got restricted gfp_t
fs/dlm/lock.c:852:64: warning: incorrect type in argument 2 (different base types)
fs/dlm/lock.c:852:64: expected restricted gfp_t [usertype] flags
fs/dlm/lock.c:852:64: got unsigned long
fs/dlm/lock.c:4136:27: warning: incorrect type in argument 1 (different base types)
fs/dlm/lock.c:4136:27: expected unsigned long [unsigned] [usertype] size
fs/dlm/lock.c:4136:27: got restricted gfp_t
fs/dlm/lock.c:4136:39: warning: incorrect type in argument 2 (different base types)
fs/dlm/lock.c:4136:39: expected restricted gfp_t [usertype] flags
fs/dlm/lock.c:4136:39: got unsigned long

Line 852 is:
warned = kmalloc(GFP_KERNEL, num_nodes * sizeof(int));
Line 4136 is:
ms_stub = kmalloc(GFP_KERNEL, sizeof(struct dlm_message));

and at least one of the defs of kmalloc is:
slab_def.h:static __always_inline void *kmalloc(size_t size, gfp_t flags)

Given that I haven't got a clue how to test a dlm, it's probably
best that you patch it.

I noticed in your patch:

where you had done a kmalloc->kzalloc transform you kept the swap.

This looks like new code in 3.0rc so I don't think you could quite
call it a regression, but it should probably be fixed fairly quickly
I guess.

-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ | | In Hex /
\ _________________________|_____ |_______/

 \ /
  Last update: 2011-07-10 02:33    [W:0.045 / U:3.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site