lkml.org 
[lkml]   [2011]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] regmap: Add I2C bus support
Hi Mark,

On Sat, Jul 09, 2011 at 01:50:42PM +0900, Mark Brown wrote:

> +#include <linux/regmap.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>

I second Lars-Peter with init.h here (from his first review).

> +static int regmap_i2c_read(struct device *dev,
> + const void *reg, size_t reg_size,
> + void *val, size_t val_size)
> +{
> + struct i2c_client *i2c = to_i2c_client(dev);
> + struct i2c_msg xfer[2];
> + int ret;
> +
> + if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_PROTOCOL_MANGLING))
> + return -ENOTSUPP;

Even more here. MANGLING is not needed for reading (and it will fail for a
number of i2c-masters).

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-07-09 13:55    [from the cache]
©2003-2011 Jasper Spaans