lkml.org 
[lkml]   [2011]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[085/107] hfsplus: add missing call to bio_put()
    2.6.39-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Seth Forshee <seth.forshee@canonical.com>

    commit 50176ddefa4a942419cb693dd2d8345bfdcde67c upstream.

    hfsplus leaks bio objects by failing to call bio_put() on the bios
    it allocates. Add the missing call to fix the leak.

    Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/hfsplus/wrapper.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    --- a/fs/hfsplus/wrapper.c
    +++ b/fs/hfsplus/wrapper.c
    @@ -36,6 +36,7 @@ int hfsplus_submit_bio(struct block_devi
    {
    DECLARE_COMPLETION_ONSTACK(wait);
    struct bio *bio;
    + int ret = 0;

    bio = bio_alloc(GFP_NOIO, 1);
    bio->bi_sector = sector;
    @@ -54,8 +55,10 @@ int hfsplus_submit_bio(struct block_devi
    wait_for_completion(&wait);

    if (!bio_flagged(bio, BIO_UPTODATE))
    - return -EIO;
    - return 0;
    + ret = -EIO;
    +
    + bio_put(bio);
    + return ret;
    }

    static int hfsplus_read_mdb(void *bufptr, struct hfsplus_wd *wd)



    \
     
     \ /
      Last update: 2011-07-08 07:15    [W:0.019 / U:2.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site