| Date | Thu, 07 Jul 2011 17:16:58 -0700 | From | Greg KH <> | Subject | [086/107] md: avoid endless recovery loop when waiting for fail device to complete. |
| |
2.6.39-stable review patch. If anyone has any objections, please let us know.
------------------
From: NeilBrown <neilb@suse.de>
commit 4274215d24633df7302069e51426659d4759c5ed upstream.
If a device fails in a way that causes pending request to take a while to complete, md will not be able to immediately remove it from the array in remove_and_add_spares. It will then incorrectly look like a spare device and md will try to recover it even though it is failed. This leads to a recovery process starting and instantly aborting over and over again.
We should check if the device is faulty before considering it to be a spare. This will avoid trying to start a recovery that cannot proceed.
This bug was introduced in 2.6.26 so that patch is suitable for any kernel since then.
Reported-by: Jim Paradis <james.paradis@stratus.com> Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/md/md.c | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -7062,6 +7062,7 @@ static int remove_and_add_spares(mddev_t list_for_each_entry(rdev, &mddev->disks, same_set) { if (rdev->raid_disk >= 0 && !test_bit(In_sync, &rdev->flags) && + !test_bit(Faulty, &rdev->flags) && !test_bit(Blocked, &rdev->flags)) spares++; if (rdev->raid_disk < 0
|