Messages in this thread | | | Date | Fri, 8 Jul 2011 13:57:52 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2/2] Staging: comedi: fix wraning:line over 80 character issue in rtd520.c |
| |
On Fri, Jul 08, 2011 at 04:07:39PM +0530, ravishankar wrote: > From: Ravishankar <ravi.shankar@greenturtles.in> > > This is a patch to the rtd520.c file that fixes up a line over 80 charcter warning found by the checkpatch.pl tool > > Signed-off-by: Ravishankar <ravishankarkm32@gmail.com> > --- > drivers/staging/comedi/drivers/rtd520.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c > index 7f09ed7..44dbf43 100644 > --- a/drivers/staging/comedi/drivers/rtd520.c > +++ b/drivers/staging/comedi/drivers/rtd520.c > @@ -1403,7 +1403,8 @@ static int ai_read_dregs(struct comedi_device *dev, struct comedi_subdevice *s) > > d = d >> 3; /* low 3 bits are marker lines */ > if (CHAN_ARRAY_TEST(devpriv->chanBipolar, s->async->cur_chan)) > - sample = d + 2048; /* convert to comedi unsigned data */ > + /* convert to comedi unsigned data */ > + sample = d + 2048;
While this will work, it's not a good idea. Please put braces in here if you are going to do this.
greg k-h
| |