lkml.org 
[lkml]   [2011]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/12] gma500: Re-order checks and dereferences in psb_intel_lvds
On Fri, Jul 08, 2011 at 09:43:15AM +0100, Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> Dan Carpenter reports:
>
> Smatch complains about 6a7afe3acc4b "gma500: continue abstracting
> platform specific code"
>
> drivers/staging/gma500/psb_intel_lvds.c +579 psb_intel_lvds_set_property(7)
> warn: variable dereferenced before check 'encoder'
>
> --- a/drivers/staging/gma500/psb_intel_lvds.c
> +++ b/drivers/staging/gma500/psb_intel_lvds.c
> @@ -575,11 +575,12 @@ int psb_intel_lvds_set_property(struct drm_connector
> *connector,
> struct drm_property *property,
> uint64_t value)
> {
> - struct drm_encoder *pEncoder = connector->encoder;
> + struct drm_encoder *encoder = connector->encoder;
> + struct drm_psb_private *dev_priv = encoder->dev->dev_private;
> ^^^^^^^^^^^^
> dereference encoder here.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>

Oh that played hell with git, please don't do that again...



\
 
 \ /
  Last update: 2011-07-08 23:03    [W:0.101 / U:4.400 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site