lkml.org 
[lkml]   [2011]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dw_spi: Add spi number into spi irq desc
Hi Shuo,

Looks ok to me, and thanks for the fix. One nit is do we have to use a char[48]
for the name?

Thanks,
Feng

On Fri, 8 Jul 2011 11:51:05 +0800
"Liu, ShuoX" <shuox.liu@intel.com> wrote:

> From 2efa9dbb5c4b1d8fa798d1792498ae21fc3a9d04 Mon Sep 17 00:00:00 2001
> From: ShuoX Liu <shuox.liu@intel.com>
> Date: Thu, 7 Jul 2011 16:09:41 +0800
> Subject: [PATCH] dw_spi: Add spi number into spi irq desc
>
> Signed-off-by: ShuoX Liu <shuox.liu@intel.com>
> ---
> drivers/spi/dw_spi.c | 4 +++-
> drivers/spi/dw_spi.h | 1 +
> 2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
> index 919fa9d..68a3026 100644
> --- a/drivers/spi/dw_spi.c
> +++ b/drivers/spi/dw_spi.c
> @@ -818,9 +818,11 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
> dws->prev_chip = NULL;
> dws->dma_inited = 0;
> dws->dma_addr = (dma_addr_t)(dws->paddr + 0x60);
> + snprintf(dws->name, sizeof(dws->name), "dw_spi%d",
> + dws->bus_num);
>
> ret = request_irq(dws->irq, dw_spi_irq, IRQF_SHARED,
> - "dw_spi", dws);
> + dws->name, dws);
> if (ret < 0) {
> dev_err(&master->dev, "can not get IRQ\n");
> goto err_free_master;
> diff --git a/drivers/spi/dw_spi.h b/drivers/spi/dw_spi.h
> index 7a5e78d..c7b9165 100644
> --- a/drivers/spi/dw_spi.h
> +++ b/drivers/spi/dw_spi.h
> @@ -96,6 +96,7 @@ struct dw_spi {
> struct spi_device *cur_dev;
> struct device *parent_dev;
> enum dw_ssi_type type;
> + char name[48];
>
> void __iomem *regs;
> unsigned long paddr;




\
 
 \ /
  Last update: 2011-07-08 06:37    [W:0.031 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site