Messages in this thread | | | From | Sachin Sanap <> | Date | Thu, 7 Jul 2011 23:20:03 -0700 | Subject | RE: [047/107] pxa168_eth: fix race in transmit path. |
| |
ACK.
> -----Original Message----- > From: Greg KH [mailto:gregkh@suse.de] > Sent: Friday, July 08, 2011 5:46 AM > To: linux-kernel@vger.kernel.org; stable@kernel.org > Cc: stable-review@kernel.org; torvalds@linux-foundation.org; akpm@linux- > foundation.org; alan@lxorguk.ukuu.org.uk; Sachin Sanap; Zhangfei Gao; > Philip Rakity; Richard Cochran; Eric Dumazet; David S. Miller > Subject: [047/107] pxa168_eth: fix race in transmit path. > > 2.6.39-stable review patch. If anyone has any objections, please let us > know. > > ------------------ > > From: Richard Cochran <richardcochran@gmail.com> > > commit 384420409d9b5d4443940abace49363d26135412 upstream. > > Because the socket buffer is freed in the completion interrupt, it is not > safe to access it after submitting it to the hardware. > > Cc: Sachin Sanap <ssanap@marvell.com> > Cc: Zhangfei Gao <zgao6@marvell.com> > Cc: Philip Rakity <prakity@marvell.com> > Signed-off-by: Richard Cochran <richard.cochran@omicron.at> > Acked-by: Eric Dumazet <eric.dumazet@gmail.com> > Signed-off-by: David S. Miller <davem@davemloft.net> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > --- > drivers/net/pxa168_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/pxa168_eth.c > +++ b/drivers/net/pxa168_eth.c > @@ -1273,7 +1273,7 @@ static int pxa168_eth_start_xmit(struct > wmb(); > wrl(pep, SDMA_CMD, SDMA_CMD_TXDH | SDMA_CMD_ERD); > > - stats->tx_bytes += skb->len; > + stats->tx_bytes += length; > stats->tx_packets++; > dev->trans_start = jiffies; > if (pep->tx_ring_size - pep->tx_desc_count <= 1) { >
| |