lkml.org 
[lkml]   [2011]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[104/107] xfrm: Fix off by one in the replay advance functions
    2.6.39-stable review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Steffen Klassert <steffen.klassert@secunet.com>

    [ Upstream commit e756682c8baa47da1648c0c016e9f48ed66bc32d ]

    We may write 4 byte too much when we reinitialize the anti replay
    window in the replay advance functions. This patch fixes this by
    adjusting the last index of the initialization loop.

    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    net/xfrm/xfrm_replay.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/net/xfrm/xfrm_replay.c
    +++ b/net/xfrm/xfrm_replay.c
    @@ -265,7 +265,7 @@ static void xfrm_replay_advance_bmp(stru
    bitnr = bitnr & 0x1F;
    replay_esn->bmp[nr] |= (1U << bitnr);
    } else {
    - nr = replay_esn->replay_window >> 5;
    + nr = (replay_esn->replay_window - 1) >> 5;
    for (i = 0; i <= nr; i++)
    replay_esn->bmp[i] = 0;

    @@ -471,7 +471,7 @@ static void xfrm_replay_advance_esn(stru
    bitnr = bitnr & 0x1F;
    replay_esn->bmp[nr] |= (1U << bitnr);
    } else {
    - nr = replay_esn->replay_window >> 5;
    + nr = (replay_esn->replay_window - 1) >> 5;
    for (i = 0; i <= nr; i++)
    replay_esn->bmp[i] = 0;




    \
     
     \ /
      Last update: 2011-07-08 07:15    [W:3.842 / U:0.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site