Messages in this thread | | | Date | Thu, 7 Jul 2011 12:51:40 +0400 | Subject | Re: [GIT PULL] ext4 update for 3.0 | From | Maxim Patlasov <> |
| |
Hi Ted,
> Yongqiang Yang (1): > ext4: correct comments for ext4_free_blocks()
Any ideas why the patch fixing accounting of i_blocks in ext4_free_blocks() didn't come to this set of changes?
The problem was that ext4_free_blocks() calls dquot_free_block() that, in turn, calls inode_sub_bytes() decrementing i_blocks. This works fine in most cases but the one: ext4_ext_map_blocks() might call ext4_free_blocks (if ext4_ext_insert_extent failed) when allocated blocks were only reserved, i.e. not accounted in i_blocks yet.
I recently re-run a simple test reproducing the problem and found out that Linus' 3.0.0-rc6 is still affected by this problem. Does it make sense to resend that patch to you?
Thanks, Maxim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |