Messages in this thread |  | | Date | Thu, 07 Jul 2011 11:33:34 -0700 | | From | Andi Kleen <> | | Subject | Re: [PATCH] x86: Fix memory leak of init_vdso_vars() |
| |
On 7/7/2011 6:14 AM, Michal Hocko wrote: > On Tue 05-07-11 14:21:48, wzt wrote: >> Fix memory leak of init_vdso_vars(). >> >> Signed-off-by: Zhitong Wang<zhitong.wangzt@alibaba-inc.com> > The patch looks correct but it could be cleaned up a bit IMO. > See bellow.
When you run out of memory at early system boot (this is early system boot only) the system is toast anyways. There's no way to recover.
I would just add a few GFP_PANICs and then drop the error paths.
-Andi
|  |