lkml.org 
[lkml]   [2011]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] dmaengine: remove ste_dma40 from issue_pending TODO
    From
    2011/7/7 Vinod Koul <vkoul@infradead.org>:
    > On Sun, 2011-06-26 at 23:29 +0200, Per Forlin wrote:
    >> ste_dma40 now implements issue_pending according to documentation.
    >> Submit adds descriptos to a pending queue with are flushed down to the DMAC
    >> at issue_pending.
    >>
    >> Signed-off-by: Per Forlin <per.forlin@linaro.org>
    > How about the client driver which are currently using this driver, wont
    > they break as they would be calling submit and not issue_pending...?

    They all call both, so it works fine. First submit() then issue_pending()
    in sucession.

    In-tree drivers:
    drivers/tty/serial/amba-pl011.c
    drivers/mmc/host/mmci.c
    drivers/spi/spi-pl022.c

    So:
    Acked-by: Linus Walleij <linus.walleij@linaro.org>

    Thanks,
    Linus Walleij


    \
     
     \ /
      Last update: 2011-07-07 16:29    [W:0.022 / U:60.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site