lkml.org 
[lkml]   [2011]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3] x86: ret_from_fork: use symbolic contants for bits in EFLAGS
    From
    On Tue, Jul 5, 2011 at 4:00 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
    > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    > Cc: x86@kernel.org
    > ---
    >  arch/x86/kernel/entry_32.S |    2 +-
    >  arch/x86/kernel/entry_64.S |    2 +-
    >  2 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
    > index 5c1a9197..f032530 100644
    > --- a/arch/x86/kernel/entry_32.S
    > +++ b/arch/x86/kernel/entry_32.S
    > @@ -303,7 +303,7 @@ ENTRY(ret_from_fork)
    >        call schedule_tail
    >        GET_THREAD_INFO(%ebp)
    >        popl_cfi %eax
    > -       pushl_cfi $0x0202               # Reset kernel eflags
    > +       pushl_cfi $(X86_EFLAGS_IF|0x2)  # Reset kernel eflags
    >        popfl_cfi
    >        jmp syscall_exit
    >        CFI_ENDPROC
    > diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
    > index 9c28bd5..4c76abf 100644
    > --- a/arch/x86/kernel/entry_64.S
    > +++ b/arch/x86/kernel/entry_64.S
    > @@ -399,7 +399,7 @@ ENTRY(ret_from_fork)
    >
    >        call schedule_tail                      # rdi: 'prev' task parameter
    >
    > -       pushq_cfi $0x0202
    > +       pushq_cfi $(X86_EFLAGS_IF|0x2)
    >        popfq_cfi                               # reset kernel eflags
    >
    >        GET_THREAD_INFO(%rcx)

    Reviewed-by: Pekka Enberg <penberg@kernel.org>
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-06 11:39    [W:0.022 / U:91.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site