lkml.org 
[lkml]   [2011]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] Staging: comedi: fix warning: line over 80 characters issue in usbduxfast.c
On Wed, Jul 06, 2011 at 01:56:50PM +0530, Ravishankar wrote:
> - ret = request_firmware_nowait(THIS_MODULE,
> - FW_ACTION_HOTPLUG,
> - "usbduxfast_firmware.bin",
> - &udev->dev,
> - GFP_KERNEL,
> - usbduxfastsub + index,
> - usbduxfast_firmware_request_complete_handler);
> + ret =
> + request_firmware_nowait(THIS_MODULE,
> + FW_ACTION_HOTPLUG,
> + "usbduxfast_firmware.bin",
> + &udev->dev,
> + GFP_KERNEL,
> + usbduxfastsub + index,
> + usbduxfast_firmware_request_complete_handler);
> +

No. Don't do this. The "usbduxfast_firmware_request_complete_handler"
variable name is too long. Rename it something shorter.

regards,
dan carpenter



\
 
 \ /
  Last update: 2011-07-06 10:47    [W:0.036 / U:7.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site