Messages in this thread | | | Date | Wed, 6 Jul 2011 14:16:04 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] FDPIC: Fix memory leak |
| |
On Wed, 06 Jul 2011 12:26:05 +0100 David Howells <dhowells@redhat.com> wrote:
> From: Davidlohr Bueso <dave@gnu.org> > > The shdr4extnum variable isn't being freed in the cleanup process of > elf_fdpic_core_dump(). > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > Signed-off-by: David Howells <dhowells@redhat.com> > --- > > fs/binfmt_elf_fdpic.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index 63039ed..2bc5dc6 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -1864,6 +1864,7 @@ cleanup: > kfree(psinfo); > kfree(notes); > kfree(fpu); > + kfree(shdr4extnum); > #ifdef ELF_CORE_COPY_XFPREGS > kfree(xfpu); > #endif
So if it dumps core often enough, the machine runs out of memory and dies. I added a cc:stable to my copy of this one.
| |