lkml.org 
[lkml]   [2011]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] regulator/tps65912: storing error codes in u8
Hi Liam,

On Mon, Jul 04, 2011 at 05:06:58PM +0100, Liam Girdwood wrote:
> On Thu, 2011-06-23 at 08:57 +0300, Dan Carpenter wrote:
> > get_ctrl_reg() returns -EINVAL so the error handling won't work here
> > if reg is a u8.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
> > index d2c6542..3a9313e 100644
> > --- a/drivers/regulator/tps65912-regulator.c
> > +++ b/drivers/regulator/tps65912-regulator.c
> > @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
> > struct tps65912_reg *pmic = rdev_get_drvdata(dev);
> > struct tps65912 *mfd = pmic->mfd;
> > int id = rdev_get_id(dev);
> > - u8 reg;
> > + int reg;
> >
> > if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
> > return -EINVAL;
>
> Samuel, would you mind taking this since tps65912 is upstreaming via
> mfd.
Sure. Would you mind sending the patch to me ?

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2011-07-06 20:33    [W:0.103 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site