Messages in this thread | | | From | Richard Weinberger <> | Subject | Re: [PATCH 1/4] uml: cow_user.c warning corrections | Date | Tue, 5 Jul 2011 11:28:24 +0200 |
| |
Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov: > From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001 > From: Vitaliy Ivanov <vitalivanov@gmail.com> > Date: Tue, 5 Jul 2011 01:57:51 +0300 > Subject: [PATCH 1/4] uml: cow_user.c warning corrections > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > arch/um/drivers/cow_user.c: In function ‘absolutize’: > arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of > ‘chdir’, declared with attribute warn_unused_result
What compiler flags are you using? Using the default settings this warning does not show up. Most of the "ignoring return value" are totally useless.
> Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com> > --- > arch/um/drivers/cow_user.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/arch/um/drivers/cow_user.c b/arch/um/drivers/cow_user.c > index 93f227a..9cbb426 100644 > --- a/arch/um/drivers/cow_user.c > +++ b/arch/um/drivers/cow_user.c > @@ -186,7 +186,11 @@ static int absolutize(char *to, int size, char *from) > strcat(to, "/"); > strcat(to, from); > } > - chdir(save_cwd); > + if (chdir(save_cwd)) { > + cow_printf("absolutize : Can't cd to '%s' - " > + "errno = %d\n", save_cwd, errno); > + return -1; > + }
I don't think that this check is needed nor chdir() to save_cwd can fail. Because we obtain it by calling getcwd() and never change it...
Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |