Messages in this thread | | | Date | Tue, 05 Jul 2011 15:39:54 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/2] x86: give names to realmode wakeup flags |
| |
On 07/04/2011 03:35 PM, Kees Cook wrote: > Instead of using literals, use a common set of names for the > user-controlled realmode wakeup flags. > > Signed-off-by: Kees Cook <kees.cook@canonical.com>
I'm sorry, but I really have to complain about this:
This was a very unfriendly thing to do. You took a patch that is a bug fix to be considered for -stable, and you applied it *on top of a cleanup patch*. They should not have been part of the same patchset, but *certainly* not in that order.
Please resubmit.
-hpa
| |