lkml.org 
[lkml]   [2011]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86: give names to realmode wakeup flags
On 07/04/2011 03:35 PM, Kees Cook wrote:
> Instead of using literals, use a common set of names for the
> user-controlled realmode wakeup flags.
>
> Signed-off-by: Kees Cook <kees.cook@canonical.com>

I'm sorry, but I really have to complain about this:

This was a very unfriendly thing to do. You took a patch that is a bug
fix to be considered for -stable, and you applied it *on top of a
cleanup patch*. They should not have been part of the same patchset,
but *certainly* not in that order.

Please resubmit.

-hpa


\
 
 \ /
  Last update: 2011-07-06 00:43    [W:0.055 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site