lkml.org 
[lkml]   [2011]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [RFC 5/8] remoteproc: add davinci implementation
    Date
    > From: Nori, Sekhar
    > Sent: Monday, July 04, 2011 10:30 PM

    ...
    > > > https://patchwork.kernel.org/patch/662941/
    > >
    > > Yes, I like this idea - much cleaner. For example, the start() method
    > > becomes (pseudo-code):
    > >
    > > start()
    > > {
    > > /* bootaddrreg derived from platform data */
    > > bootaddrreg = boot_address;
    > >
    > > clk_enable();
    > > }
    > >
    > > Referring to your patch above, would it be better to just pass
    > > the flags into the davinci_psc_config() function rather than breaking
    > out more
    > > arguments for each flag?
    >
    > I did dwell on this quite a bit while writing that
    > patch, but finally decided on passing an argument
    > instead since I was not sure if there are going
    > to be more modifiers required.
    >
    > Now that you have the need for one more flag, I
    > think we should go ahead and pass the flags directly
    > to davinci_psc_config(). My original patch is not
    > upstream yet. I will re-spin it and you can build
    > on top of it.

    Thanks, Sekhar, this sounds good. I'll look for your patch and utilize
    it in the next rev of this patch.

    Mark



    \
     
     \ /
      Last update: 2011-07-05 18:57    [W:0.049 / U:60.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site