lkml.org 
[lkml]   [2011]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/77] Staging: hv: vmbus: Introduce a function to map the dev_type guid to a name
    On Thu, Jun 16, 2011 at 01:16:40PM -0700, K. Y. Srinivasan wrote:
    > In preparation for introducing machinery to support autoloading vmbus
    > drivers, introduce a function to map the dev_type guid to a human readable name.

    "Human readable"?

    <snip>

    > +static const char *blk_dev_type = "hv_block";
    > +static const char *net_dev_type = "hv_net";
    > +static const char *scsi_dev_type = "hv_scsi";
    > +static const char *mouse_dev_type = "hv_mouse";
    > +static const char *util_dev_type = "hv_util";

    It looks like these are the module names, which aren't the most "human
    readable" around.

    > +/*
    > + * Map the dev_type guid to a human readable string for setting
    > + * up module aliases. The indices used in this function are based on
    > + * the table defined earlier - supported_device_classes[]
    > + */
    > +const char *hv_get_devtype_name(const struct hv_guid *type)
    > +{
    > + int i;
    > +
    > + for (i = 0; i < MAX_NUM_DEVICE_CLASSES_SUPPORTED; i++) {
    > + if (!memcmp(type, supported_device_classes[i].data,
    > + sizeof(struct hv_guid))) {
    > + switch (i) {
    > + case 0:
    > + return scsi_dev_type;
    > + case 1:
    > + return net_dev_type;
    > + case 2:
    > + return mouse_dev_type;
    > + case 3:
    > + return blk_dev_type;
    > + }
    > + }
    > + }
    > + /*
    > + * Currently the util driver is used
    > + * to handle all these devices.
    > + */
    > + return util_dev_type;
    > +}

    Ok, you create a function to return a string, but I'm really afraid of
    what you are going to do in the next patch with this...



    \
     
     \ /
      Last update: 2011-07-05 18:11    [W:3.546 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site