Messages in this thread | | | From | Richard Weinberger <> | Subject | Re: [PATCH][Resend v2] Fix infinite loop in search_binary_handler() | Date | Tue, 5 Jul 2011 14:21:02 +0200 |
| |
Am Dienstag 05 Juli 2011, 14:02:34 schrieb Tetsuo Handa: > Richard Weinberger wrote: > > But IMHO adding a new attribute to task_struct is a bit overkill. > > Why is your variant better than my strcmp() in fs/exec.c? > > Say, there are multiple /sbin/modprobe > > /sbin/modprobe > /var/chroot/sbin/modprobe > > and only /var/chroot/sbin/modprobe needs request_module() whereas > /sbin/modprobe does not need request_module(). Why do we need to make > execl("/sbin/modprobe", "--help", NULL) from chroot("/var/chroot/") fail > by denying request_module() that does not cause recursion?
*headdesk*, bprm->filename will contain "/sbin/modprobe" and the strcmp() will falsely match. Thanks for the pointer!
//richard
| |