Messages in this thread |  | | Subject | Re: [PATCH] perf: Extend attr check to allow also dynamically generated | | From | Peter Zijlstra <> | | Date | Tue, 05 Jul 2011 12:51:00 +0200 |
| |
On Tue, 2011-07-05 at 11:47 +0200, Robert Richter wrote:
> From 63e76c3d827e3d6d24ff4ee24854523c054c7179 Mon Sep 17 00:00:00 2001 > From: Robert Richter <robert.richter@amd.com> > Date: Tue, 5 Jul 2011 11:04:39 +0200 > Subject: [PATCH] perf: Extend attr check to allow also dynamically generated > types > > When attaching events to a pmu with generated type, the initialization > fails. Extending the check to allow such types. > > Signed-off-by: Robert Richter <robert.richter@amd.com> > --- > kernel/events/core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index cca3588..5900729 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -5958,7 +5958,7 @@ static int perf_copy_attr(struct perf_event_attr __user *uattr, > * If the type exists, the corresponding creation will verify > * the attr->config. > */ > - if (attr->type >= PERF_TYPE_MAX) > + if (attr->type >= PERF_TYPE_MAX && !idr_find(&pmu_idr, attr->type)) > return -EINVAL; > > if (attr->__reserved_1)
Lin Ming submitted a similar patch:
http://marc.info/?l=linux-kernel&m=130942109729864
Which I prefer as it removes code. Event creation will fail in perf_init_event() in that case when an invalid type is specified.
|  |