| Date | Sat, 30 Jul 2011 22:36:48 -0700 | Subject | Re: [PATCH 15/18] dmaengine/amba-pl08x: Pass flow controller information with slave channel data | From | viresh kumar <> |
| |
On 7/30/11, Linus Walleij <linus.walleij@linaro.org> wrote: > 2011/7/29 Viresh Kumar <viresh.kumar@st.com>: > > I have the same comment as Russell basically: > >> @@ -65,6 +69,7 @@ struct pl08x_channel_data { >> int max_signal; >> u32 muxval; >> u32 cctl; >> + u32 fc; > > bool device_fc; > > or similar. Then encode the necessary bits if the device controls > flow, and fall back to default (DMAC control) otherwise. >
Yes. I thought of exactly the same code.
-- viresh
|