lkml.org 
[lkml]   [2011]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the moduleh tree
[linux-next: build failure after merge of the moduleh tree] On 29/07/2011 (Fri 14:56) Stephen Rothwell wrote:

> Hi Paul,
>
> After merging the moduleh tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> arch/powerpc/platforms/cell/spu_syscalls.c: In function 'spufs_calls_get':
> arch/powerpc/platforms/cell/spu_syscalls.c:42:2: error: implicit declaration of function 'try_module_get'
> arch/powerpc/platforms/cell/spu_syscalls.c: In function 'spufs_calls_put':
> arch/powerpc/platforms/cell/spu_syscalls.c:54:2: error: implicit declaration of function 'module_put'
>
> Caused by commit f7f927183dba ("powerpc: various straight conversions
> from module.h --> export.h"). This file should not be modified.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 29 Jul 2011 14:53:16 +1000
> Subject: [PATCH] Partial revert of f7f927183dba

Thanks, I've dropped the offending hunk from its origin.

Paul.

>
> "powerpc: various straight conversions from module.h --> export.h"
>
> This file needs module.h.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/powerpc/platforms/cell/spu_syscalls.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/cell/spu_syscalls.c b/arch/powerpc/platforms/cell/spu_syscalls.c
> index 60fc5ec..75530d9 100644
> --- a/arch/powerpc/platforms/cell/spu_syscalls.c
> +++ b/arch/powerpc/platforms/cell/spu_syscalls.c
> @@ -22,7 +22,7 @@
> */
> #include <linux/file.h>
> #include <linux/fs.h>
> -#include <linux/export.h>
> +#include <linux/module.h>
> #include <linux/syscalls.h>
> #include <linux/rcupdate.h>
>
> --
> 1.7.5.4
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/


\
 
 \ /
  Last update: 2011-07-31 07:47    [from the cache]
©2003-2011 Jasper Spaans