lkml.org 
[lkml]   [2011]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] rt2x00: rt2800: fix zeroing skb structure
    From
    On Sat, Jul 30, 2011 at 1:32 PM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
    > We should clear skb->data not skb itself. Bug was introduced by:
    > commit 0b8004aa12d13ec750d102ba4082a95f0107c649 "rt2x00: Properly
    > reserve room for descriptors in skbs".
    >
    > Cc: stable@kernel.org # 2.6.36+
    > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

    Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

    > ---
    >  drivers/net/wireless/rt2x00/rt2800lib.c |    3 +--
    >  1 files changed, 1 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
    > index 75d2c6c..f94d669 100644
    > --- a/drivers/net/wireless/rt2x00/rt2800lib.c
    > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
    > @@ -703,8 +703,7 @@ void rt2800_write_beacon(struct queue_entry *entry, struct txentry_desc *txdesc)
    >        /*
    >         * Add space for the TXWI in front of the skb.
    >         */
    > -       skb_push(entry->skb, TXWI_DESC_SIZE);
    > -       memset(entry->skb, 0, TXWI_DESC_SIZE);
    > +       memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE);
    >
    >        /*
    >         * Register descriptor details in skb frame descriptor.
    > --
    > 1.7.4
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-30 16:05    [W:4.814 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site