| Date | Sat, 30 Jul 2011 13:07:40 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 07/18] dmaengine/amba-pl08x: Enable/Disable amba_pclk with channel requests |
| |
On Fri, Jul 29, 2011 at 04:19:17PM +0530, Viresh Kumar wrote: > Amba devices have interface clocks attached as adev->pclk. This is the only > clock associated with DMAC and it can be disabled when DMAC is not in use. This > patch adds support to enable/disable this clk as and when channels are requested > and freed. Also it disables this clock at the end of probe.
It may make better sense to convert this to runtime PM. I suspect that there's core support which the amba/bus.c can do to help in that respect (eg, managing the apb pclk itself) so that we don't have to add the same code to every primecell driver.
|