lkml.org 
[lkml]   [2011]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 1/1] input: add driver for Bosch Sensortec's BMA150 accelerometer
    > > +static int bma150_open(struct bma150_data *bma150)
    > > +{
    > > + int ret;
    > > +
    > > + ret = pm_runtime_set_active(&bma150->client->dev);
    > > + if (ret < 0)
    > > + return ret;
    > > +
    > > + pm_runtime_enable(&bma150->client->dev);
    >
    > I am pretty sure you want to call pm_runtime_enable() in bma150_probe()
    > so that parent controller can be suspended until somebody calls
    > bma150_open() and we mark the device as active (which, in turn, should
    > wake up its parent).

    If I call pm_runtime_enable() I cannot use pm_runtime_set_active() later
    according to the comment in __pm_runtime_set_status (runtime.c):
    "If runtime PM of the device is disabled or its power.runtime_error
    field is different from zero, the status may be changed either to
    RPM_ACTIVE, or to RPM_SUSPENDED..."

    If the PM of the device is enabled it will return -EAGAIN. Of course, we
    could enable() in probe, then disable(); set_active(); enable(); in
    open, but that seems a bit confused, right?

    > > +
    > > + return bma150_set_mode(bma150->client, BMA150_MODE_NORMAL);
    > > +}
    > > +
    > > +static void bma150_close(struct bma150_data *bma150)
    > > +{
    > > + pm_runtime_disable(&bma150->client->dev);
    >
    > And disable should go into bma150_remove() unless I misunderstand
    > runtime PM framework.

    This is once again to make sure the PM is disabled when changing status.

    I am not entirely familiar with the details of runtime PM, but either
    the above works or we have to revert back to using #ifdefs which I would
    prefer not to.

    --
    Best regards,
    Eric

    http://www.unixphere.com


    \
     
     \ /
      Last update: 2011-07-31 00:47    [W:0.058 / U:2.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site