lkml.org 
[lkml]   [2011]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 06/18] dmaengine/amba-pl08x: Simplify pl08x_ensure_on()
    From
    2011/7/29 Viresh Kumar <viresh.kumar@st.com>:

    > Simply writing 1 on bit 0 is sufficient instead of reading and clearing bits.
    > Also as per manual, for bit 3-31 of DMACConfiguration register:
    > "read undefined, write as 0"
    >
    > So, we must not rely on values read from this registers bit 3-31.
    >
    > Signed-off-by: Viresh Kumar <viresh.kumar@st.com>

    Obviously correct,
    Acked-by: Linus Walleij <linus.walleij@linaro.org>

    Thanks,
    Linus Walleij


    \
     
     \ /
      Last update: 2011-07-31 00:39    [W:0.019 / U:0.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site