lkml.org 
[lkml]   [2011]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 1/1] input: add driver for Bosch Sensortec's BMA150 accelerometer
    Hi Eric,

    On Wed, Jul 27, 2011 at 10:53:47PM +0200, Eric Andersson wrote:
    > +
    > +static int bma150_open(struct bma150_data *bma150)
    > +{
    > + int ret;
    > +
    > + ret = pm_runtime_set_active(&bma150->client->dev);
    > + if (ret < 0)
    > + return ret;
    > +
    > + pm_runtime_enable(&bma150->client->dev);

    I am pretty sure you want to call pm_runtime_enable() in bma150_probe()
    so that parent controller can be suspended until somebody calls
    bma150_open() and we mark the device as active (which, in turn, should
    wake up its parent).

    > +
    > + return bma150_set_mode(bma150->client, BMA150_MODE_NORMAL);
    > +}
    > +
    > +static void bma150_close(struct bma150_data *bma150)
    > +{
    > + pm_runtime_disable(&bma150->client->dev);

    And disable should go into bma150_remove() unless I misunderstand
    runtime PM framework.

    > + pm_runtime_set_suspended(&bma150->client->dev);
    > + bma150_set_mode(bma150->client, BMA150_MODE_SLEEP);

    I think you want to call bma150_set_mode() first and then mark device as
    suspended so that parent can go to sleep as well.

    Thanks.

    --
    Dmitry


    \
     
     \ /
      Last update: 2011-07-30 21:19    [W:0.027 / U:92.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site